Skip to content

drop redundant TARGETS files that duplicate sister BUCK files (#20403)#20403

Open
bigfootjon wants to merge 1 commit into
mainfrom
export-D109082060
Open

drop redundant TARGETS files that duplicate sister BUCK files (#20403)#20403
bigfootjon wants to merge 1 commit into
mainfrom
export-D109082060

Conversation

@bigfootjon

@bigfootjon bigfootjon commented Jun 18, 2026 •
edited by meta-codesync Bot
Loading

Copy link
Copy Markdown
Member

Summary:

Initial chunk of fbcode/executorch TARGETS->BUCK migration. Removes 40
TARGETS files where:

  • 7 are byte-identical to their sister BUCK file, OR
  • 33 contain only a no-arg define_common_targets() call matching
    a sister BUCK that also calls define_common_targets() with no args

In both cases fbcode falls through to the BUCK file (via
name_v2 = TARGETS,BUCK) and evaluates the exact same content it did
before. Any TARGETS that passes any argument to define_common_targets
(positional or keyword) is intentionally excluded — those are the
is_fbcode = True cases that need a separate, more careful treatment.

Reviewed By: mzlee

Differential Revision: D109082060

Copilot AI review requested due to automatic review settings June 18, 2026 22:54
@pytorch-bot

pytorch-bot Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20403

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Unrelated Failure, 1 Unclassified Failure

As of commit 00f371f with merge base 6f6225c (image):

NEW FAILURE - The following job has failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2026
@meta-codesync

meta-codesync Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109082060.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI reviewed Jun 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes redundant fbcode TARGETS files that duplicate their sibling BUCK files as part of the ongoing TARGETS→BUCK migration, relying on the name_v2 = TARGETS,BUCK fallback to keep behavior unchanged.

Changes:

  • Deleted TARGETS files that were byte-identical to the corresponding BUCK file.
  • Deleted TARGETS files that only performed a no-arg define_common_targets() call that already exists in the corresponding BUCK.
  • No functional build target changes intended; this is a cleanup/deduplication step.

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
schema/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
schema/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/platform/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/platform/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/core/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/core/exec_aten/util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/core/exec_aten/testing_util/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/core/exec_aten/testing_util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/core/exec_aten/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/backend/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/backend/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
kernels/prim_ops/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
kernels/portable/cpu/util/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
kernels/portable/cpu/util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
kernels/optimized/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
kernels/optimized/cpu/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/threadpool/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/threadpool/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/testing_util/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/testing_util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/tensor/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/tensor/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/runner_util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/pytree/aten_util/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/pytree/aten_util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/image/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/image/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/image/benchmark/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/cuda/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/aten_util/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/aten_util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
examples/qualcomm/executor_runner/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
examples/devtools/example_runner/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
configurations/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
codegen/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
backends/qualcomm/builders/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
backends/qualcomm/aot/wrappers/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bigfootjon @meta-codesync
drop redundant TARGETS files that duplicate sister BUCK files (#20403)
00f371f 
Summary:
Pull Request resolved: #20403

Initial chunk of fbcode/executorch TARGETS->BUCK migration. Removes 40
TARGETS files where:

  - 7 are byte-identical to their sister BUCK file, OR
  - 33 contain only a no-arg `define_common_targets()` call matching
    a sister BUCK that also calls `define_common_targets()` with no args

In both cases fbcode falls through to the BUCK file (via
`name_v2 = TARGETS,BUCK`) and evaluates the exact same content it did
before. Any TARGETS that passes any argument to define_common_targets
(positional or keyword) is intentionally excluded — those are the
`is_fbcode = True` cases that need a separate, more careful treatment.

Reviewed By: mzlee

Differential Revision: D109082060
@meta-codesync meta-codesync Bot changed the title drop redundant TARGETS files that duplicate sister BUCK files drop redundant TARGETS files that duplicate sister BUCK files (#20403) Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

@abhinaykukkadapu abhinaykukkadapu Awaiting requested review from abhinaykukkadapu abhinaykukkadapu is a code owner

@psiddh psiddh Awaiting requested review from psiddh psiddh is a code owner

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia Gasoonjia is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bigfootjon